Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type fix #2119

Closed
wants to merge 2 commits into from
Closed

Type fix #2119

wants to merge 2 commits into from

Conversation

EvertEt
Copy link
Contributor

@EvertEt EvertEt commented Jan 18, 2024

Fixes #2118.

Not sure what the best way to test this is without introducing too much duplication.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided
  • commit message and code follows the Developer's Certification of Origin

@adrai
Copy link
Member

adrai commented Jan 18, 2024

//cc @marcalexiei

@EvertEt EvertEt marked this pull request as draft January 18, 2024 17:02
@marcalexiei
Copy link
Member

I’ll review this in the next days, probably in the weekend.

@EvertEt if I need to make many changes to perform the fix is ok for you if I open a new PR?
I cannot be sure at the moment but I prefer to ask right now to speed things up later ☺️

@EvertEt
Copy link
Contributor Author

EvertEt commented Jan 18, 2024

All good!

@adrai
Copy link
Member

adrai commented Jan 20, 2024

addressed in v23.7.17

@adrai adrai closed this Jan 20, 2024
@EvertEt EvertEt deleted the type-fix branch January 21, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global t does not handle arrays as defaultNS well
3 participants