Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add sponsor notice #592

Merged
merged 1 commit into from
Dec 19, 2019
Merged

chore: Add sponsor notice #592

merged 1 commit into from
Dec 19, 2019

Conversation

isaachinman
Copy link
Contributor

No description provided.

@isaachinman isaachinman merged commit 1f67bac into master Dec 19, 2019
@isaachinman isaachinman deleted the sponsor-notice branch December 19, 2019 22:33
@kachkaev
Copy link
Contributor

npmno longer recommends using postinstall script for sponsorship information. There is a new funding field in package.json, which should be used instead.

Post-install scripts are disabled by some developers (including myself) because they are a can of worms security-wise. Related discussion: yarnpkg/yarn#7761 (comment)

@kachkaev
Copy link
Contributor

Example migration from a postinstall script: styled-components/styled-components#2931

@isaachinman
Copy link
Contributor Author

Yup, I've just remembered a blog post I saw a few weeks ago and am already in the process of updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants