use funding field instead of postinstall script #2931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koba04
changed the title
|
Can you rebase this against the v5 branch and switch the merge target? ty |
koba04
force-pushed
the
use-funding-field
branch
from
4f7b630
to
7a6cbc3
Compare
|
@probablyup Thank you! I've rebased this and switched the target branch! |
|
Thanks! |
|
Thank you!!! This is huge for the ecosystem!!👏👏👏 |
This was referenced Mar 4, 2020
Merged
Merged
This was referenced Mar 10, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for the amazing library!!!
npm supports the
fundingfield at v6.13 and Node has updated the bundled npm version to v6.13.4 because of the vulnerability so I think many people are able to use thefundsubcommand.So could you consider to use the
fundingfield instead ofpostinstall? 🙏I understand that printing a message while installing the package is effective to reach out to many developers but the script is very dangerous so it would be nice if the ecosystem could avoid using this.
Yarn is considering to disable the script by default.
yarnpkg/yarn#7761 (comment)