Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

use funding field instead of postinstall script #2931

Merged
merged 1 commit into from Dec 23, 2019

Conversation

@koba04
Copy link
Contributor

koba04 commented Dec 18, 2019

Thank you for the amazing library!!!

npm supports thefunding field at v6.13 and Node has updated the bundled npm version to v6.13.4 because of the vulnerability so I think many people are able to use the fund subcommand.

So could you consider to use the funding field instead of postinstall? 馃檹
I understand that printing a message while installing the package is effective to reach out to many developers but the script is very dangerous so it would be nice if the ecosystem could avoid using this.
Yarn is considering to disable the script by default.
yarnpkg/yarn#7761 (comment)

@koba04 koba04 changed the title use funding field instead of post install script use funding field instead of postinstall script Dec 18, 2019
Copy link
Contributor

probablyup left a comment

I'm fine with this

@probablyup probablyup changed the base branch from master to v5 Dec 22, 2019
@probablyup probablyup changed the base branch from v5 to master Dec 22, 2019
@probablyup

This comment has been minimized.

Copy link
Contributor

probablyup commented Dec 22, 2019

Can you rebase this against the v5 branch and switch the merge target? ty

@koba04 koba04 force-pushed the koba04:use-funding-field branch from 4f7b630 to 7a6cbc3 Dec 23, 2019
@koba04 koba04 changed the base branch from master to v5 Dec 23, 2019
@koba04

This comment has been minimized.

Copy link
Contributor Author

koba04 commented Dec 23, 2019

@probablyup Thank you! I've rebased this and switched the target branch!

@probablyup

This comment has been minimized.

Copy link
Contributor

probablyup commented Dec 23, 2019

Thanks!

@probablyup probablyup merged commit 9aaac33 into styled-components:v5 Dec 23, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@koba04

This comment has been minimized.

Copy link
Contributor Author

koba04 commented Dec 23, 2019

Thank you!!! This is huge for the ecosystem!!馃憦馃憦馃憦

@koba04 koba04 deleted the koba04:use-funding-field branch Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.