Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reload translations whenever namespaces passed to useTranslation() change #878

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Reload translations whenever namespaces passed to useTranslation() change #878

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/useTranslation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export function useTranslation(ns, props = {}) {
if (bindI18nStore && i18n)
bindI18nStore.split(' ').forEach(e => i18n.store.off(e, boundReset));
};
}, []); // define props to trigger using effect on rerender (none here)
}, [namespaces.join()]); // re-run effect whenever list of namespaces changes
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it might be safer not to rely on object identity in case people pass inlined arrays like useTranslation(["x", "y"]) that are recreated on every render. That's why I'm turning the namespaces array into a string first.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes...saw that...think that's rather clever


const ret = [t.t, i18n, ready];
ret.t = t.t;
Expand Down