Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "split none" command #3808

Open
jbriales opened this issue Sep 30, 2019 · 2 comments

Comments

@jbriales
Copy link

@jbriales jbriales commented Sep 30, 2019

I'm submitting a…

[ ] Bug
[x] Feature Request
[ ] Documentation Request
[ ] Other (Please describe in detail)

Current Behavior

When doing a container split (by either split h or split v), there is no simple way afaict to make the container back to non-split.

Desired Behavior

Have an additional split command like split none or split no so that we can revert a container with a single window to be non-split again.

Environment

Output of i3 --moreversion 2>&-:

Binary i3 version:  4.16.1 (2019-01-27) © 2009 Michael Stapelberg and contributors
Running i3 version: 4.16.1 (2019-01-27) (pid 3293)abort…)
Loaded i3 config: /home/jesusbriales/.i3/config (Last modified: Mon 30 Sep 2019 01:10:15 PM IST, 465 seconds ago)

The i3 binary you just called: /usr/bin/i3
The i3 binary you are running: i3
- Linux Distribution & Version: Fedora 29
- Are you using a compositor (e.g., xcompmgr or compton): No
@i3bot i3bot added the enhancement label Sep 30, 2019
@xzfc

This comment has been minimized.

Copy link
Contributor

@xzfc xzfc commented Oct 3, 2019

there is no simple way afaict to make the container back to non-split.

A workaround exists: https://www.freelists.org/post/i3-discuss/Killing-Singleton-Parents,1

@Airblader Airblader added the 4.17 label Oct 6, 2019
@Airblader

This comment has been minimized.

Copy link
Member

@Airblader Airblader commented Oct 6, 2019

I've seen this issue pop up a few times, so I think adding a command for this would be alright. However, note that we cannot change the split toggle behavior as that would probably break things for a lot of users (but we could do the same we did for layout toggle).

Also note that the restriction on it working only on a window which is the single child of its parent is important here and we should reject this command for other scenarios.

@Airblader Airblader added the accepted label Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.