Implement split none command

[rpigott]

While browsing the i3 issue tracker I saw issue i3/i3#3808 "split none" command with an accepted label.

Not sure if we want it yet, but I figured this one was pretty easy to implement for sway so here it is. i3 doesn't have an implementation yet, so I can't really compare it to theirs, but I expect this is the intended behavior.

[RedSoxFan]

The workspace needs to be arranged after the flatten. Reference the do_split function at the top of the file:

sway/sway/commands/split.c

Lines 30 to 34 in 8170a23

	if (root->fullscreen_global) {
	arrange_root();
	} else {
	arrange_workspace(ws);
	}

Since this is for i3 compatibility, this should not be merged until the feature lands in i3 master. This is especially important since there is no active PR to mirror the behavior against. The linked i3 issue also suggests rejecting the command (CMD_FAILURE) when there are siblings, which isn't currently implemented in this PR.

[rpigott]

Just updated since this was stale and had a conflict. No change in the i3 situation AFAIK.

[RedSoxFan]

Code LGTM. Not sure if this should be merged yet.

[jhonrocha]

Hey! i3 currently have a workaround for this: https://www.youtube.com/watch?v=AWA8Pl57UBY&t=278s
However, I am not able to reproduce that behavior on sway, trying to move a single child against its parent is actually moving the parent towards the selected direction. Is there a way to reproduce that?

[rpigott]

@jhonrocha That should be fixed in master. If not, please file a new bug for it. i3 has entered a feature freeze and I'm not sure of the status of this feature for i3.

[WhyNotHugo]

Is there something blocking this from being merged?

[Xyene]

The i3 feature is not implemented, so this is blocked on that.

[emersion]

The risk here is to merge something which becomes incompatible with what i3 ends up merging.

[tamirzb]

@emersion I'm curious, why not merge this and then worst case if i3 ever ends up merging something different also add compatibility for that? sway already has features that i3 doesn't have, which risks i3 merging something incompatible with them some day in the future.

[emersion]

The i3 devs have given a provisional ACK for this API. I'd be fine with merging even if there's a risk we need to add back compat for i3 later. This is a pretty small feature.

[rpigott]

I'm fine with merging this. I think its unlikely for i3 to merge an incompatible feature, and even if they do it's unlikely to be a disaster if we change ours to match.

[emersion]

Alright, let's do this then, thanks!

[rpigott]

@emersion Uh, this doesn't actually build. I guess the CI hadn't been run in ages and it was never updated for a047b5e.

[sim590]

How is this supposed to work? I tried:

bindsym $mod+u split none

But it just didn't change anything. The V marker in front of the window title indicating that the window is in vertical split mode is still there. Isn't split none supposed to remove it so that the next window I spawn is under the same parent as the focused window?

Version info

sway version 1.6-e76e13ef

[rpigott]

Isn't split none supposed to remove it so that the next window I spawn is under the same parent as the focused window?

That sounds right. It will only work on singleton containers though, so if you've spawned another window already it will do nothing. Maybe try running swaymsg split none in your terminal from that configuration and see if it reports an error?

EDIT: btw, swaymsg -t get_workspaces will show you the full workspace representation which is useful for unambiguously communicating layouts.

[sim590]

@rpigott : you're right. If I remove the windows from the container, it seems to work. That's what I was missing I think!