unflake t/525-i3bar-mouse-bindings.t #3214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sending the sync command via IPC ensures pending IPC messages are handled by i3 before the sync response is read. This is rarely useful for direct IPC connections to i3, but becomes useful when synchronizing with i3bar, which might have pending IPC messages in response to button clicks.
i3bar’s X11 output is not what our testcases are testing — the state manipulations which i3bar triggers via IPC messages to i3 are what we are interested in.
See the comment in the code for rationale.
Airblader
approved these changes
Mar 30, 2018
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current synchronization methods were not sufficient, and hence t/525-i3bar-mouse-bindings.t was flaky: thus far, we could synchronize our X11 connection with i3 or i3bar, but we could not synchronize i3bar’s IPC connection with i3. This pull requests introduces the “sync” IPC command to address that shortcoming.
Further, it turns out we need to synchronize with both i3 and i3bar, so the pull request also fixes that.
With the pull request applied, I have not been able to get t/525-i3bar-mouse-bindings.t to fail.
related to #3009