Introduce cmp_tree test function #3510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orestisfl
changed the title
orestisfl
commented
Nov 7, 2018
testcases/t/301-tree.t
Outdated
| # • http://onyxneon.com/books/modern_perl/modern_perl_a4.pdf | ||
| # (unless you are already familiar with Perl) | ||
| # | ||
| # Contains various tests that use the cmp_tree subroutine. |
There was a problem hiding this comment.
Not sure how we should split the tests. The sanity_checks are useful to test cmp_tree itself but the rest of the tests could be moved to the files that test the specific function, eg 291-swap.t.
It would also be possible to rewrite lots of the old tests to use the new function but I think that it would be counter-productive.
orestisfl
added
the
waiting
orestisfl
commented
Nov 7, 2018
|
|
||
| =item 1. | ||
|
|
||
| Upper case letters H, V, S, T mean horizontal, vertical, stacked and tabbed |
There was a problem hiding this comment.
TODO: maybe we can also add a floating layer eg with 'F'
There was a problem hiding this comment.
But we can do this in a separate PR
stapelberg
added a commit
to stapelberg/i3
that referenced
this pull request
Dec 8, 2018
Using the wrong X11 connection breaks the libev event handling model: xcb_flush() must be called immediately before handing control to libev. Before this fix: 1. xcb_prepare_cb would read and flush conn 2. restore_xcb_prepare_cb would read and flush restore_conn, BUT also inadvertantly call xcb_flush(conn), resulting in new events being filled into the XCB event queue 3. libev waits for new events 4. after 1 minute, libev times out and the events are processed Diagnosed using strace on testcases/complete-run.pl. related to commit 0d8b671 related to i3#3510
orestisfl
force-pushed
the
tree.t
branch
2 times, most recently
from
c7ba93c
to
3402470
Compare
Related to i3#3503
|
@Airblader how would you like to continue with this PR here? |
Airblader
approved these changes
Dec 12, 2018
|
@orestisf1993 LGTM. Anything from your side? If not, feel free to merge it! |
orestisfl
changed the title
orestisfl
removed
the
waiting
|
Ok, I am merging it and we'll see if it needs improvements later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3503