Fix i3-dmenu-desktop quoting #5162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depending on the timing of the bugfix release, I can try to add tests for i3-dmenu-desktop, so let’s not merge this right away. I just wanted to send the PR so that affected folks can try it out :) |
This was referenced Sep 25, 2022
Commit 70f23ca introduced new issues. Instead of distinguishing " and \, as that commit attempted, let’s instead keep the level of escaping by escaping each backslash, just like each double quote. I tested this with: # recommended way to quote $ and " in quoted arguments, not ambiguous Exec=/tmp/logargs "hello \\$PWD \\"and\\" more" # permitted way to quote $ and " in quoted arguments, but ambiguous Exec=/tmp/logargs "hello \$PWD \"and\" more" # permitted way to quote arguments, slightly unusual to quote first arg Exec="/tmp/logargs" hey # a complicated shell expression, not ambiguous Exec=sh -c "if [ -n \\"\\$*\\" ]; then exec /tmp/logargs --alternate-editor= --display=\\"\\$DISPLAY\\" \\"\\$@\\"; else exec /tmp/logargs --alternate-editor= --create-frame; fi" placeholder %F related to i3#4697 (electrum, original) related to i3#5152 (phpstorm, breakage) related to i3#5156 (emacsclient, breakage)
|
Tests added and merged :) |
stapelberg
added a commit
that referenced
this pull request
Oct 24, 2022
Commit 70f23ca introduced new issues. Instead of distinguishing " and \, as that commit attempted, let’s instead keep the level of escaping by escaping each backslash, just like each double quote. I tested this with: # recommended way to quote $ and " in quoted arguments, not ambiguous Exec=/tmp/logargs "hello \\$PWD \\"and\\" more" # permitted way to quote $ and " in quoted arguments, but ambiguous Exec=/tmp/logargs "hello \$PWD \"and\" more" # permitted way to quote arguments, slightly unusual to quote first arg Exec="/tmp/logargs" hey # a complicated shell expression, not ambiguous Exec=sh -c "if [ -n \\"\\$*\\" ]; then exec /tmp/logargs --alternate-editor= --display=\\"\\$DISPLAY\\" \\"\\$@\\"; else exec /tmp/logargs --alternate-editor= --create-frame; fi" placeholder %F related to #4697 (electrum, original) related to #5152 (phpstorm, breakage) related to #5156 (emacsclient, breakage)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 70f23ca introduced new issues.
Instead of distinguishing " and , as that commit attempted, let’s instead keep the level of escaping by escaping each backslash, just like each double quote.
I tested this with:
related to #4697 (electrum, original)
related to #5152 (phpstorm, breakage)
related to #5156 (emacsclient, breakage)