Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if the volume device is "alsa", force using ALSA PulseAudio emulation #29

Closed
wants to merge 1 commit into from
Closed

Conversation

Watcom
Copy link
Contributor

@Watcom Watcom commented Apr 19, 2015

The ability to force using the "pulse" ALSA device (using PulseAudio through ALSA emulation) was missing. This patch makes that possible by specifying the device "alsa".

@@ -447,6 +447,8 @@ default is used. If the device string is missing or is set to "default",
PulseAudio will be tried if detected and will fallback to ALSA (Linux)
or OSS (FreeBSD/OpenBSD).

To force PulseAudio using ALSA emulation, use "alsa" as the device name.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t understand this sentence. Which API will be used when specifying “alsa” and why is it necessary to have this special case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could already force using the ALSA API by using any device name other than "pulse", "default" or missing value. The problem is that the ALSA device name for the PulseAudio backend is also "pulse", so there's no way to force using it. This is one way to address this problem.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, but why would you want to enforce using ALSA when you’re using PulseAudio via ALSA’s PulseAudio backend anyway? I don’t see the point in that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose to mimic the old behaviour, without the thread wakes, etc. A vague reason, admittedly.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I suggested it was to mimic the old behaviour since I never had problems with muted volume then. #28 however fixed that problem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, closing pull request.

@Watcom Watcom closed this Apr 19, 2015
@Watcom Watcom deleted the alsa-emul branch January 10, 2016 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants