Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ability to use your own API key. #47

Merged
merged 2 commits into from
Mar 19, 2020
Merged

Conversation

dirkschut
Copy link
Contributor

Regarding #46 and #45 .

I know the code isn't pretty in any way and that the way I'm passing the application name and API key to the service is not at all the way you're supposed to do this, but it's a quick fix that can always be revised later on.

@dirkschut
Copy link
Contributor Author

I'm outside right now so I can't really check, but I think I'm only sending the API key from the settings to the service when saving new settings. I will check in a couple of hours when I'm back home but don't pull this yet.

@dirkschut
Copy link
Contributor Author

Nevermind, it's all good,

@kldgrug
Copy link

kldgrug commented Mar 6, 2020

HI mrDLSable
Can you comment the way to create the API key
I new in this and i don´t know what type of calling is use in Youcast, to generate the APIkey

@dirkschut
Copy link
Contributor Author

@kldgrug I have written docs in my original pull request. Until @i3arnon merges my request you can read it over on my fork at: https://github.com/mrDLSable/YouCast/blob/master/README.md

@i3arnon i3arnon merged commit 3f2eb7b into i3arnon:master Mar 19, 2020
@i3arnon
Copy link
Owner

i3arnon commented Mar 19, 2020

@mrDLSable thank you very much for making this change.
I've merged it (and added some changes) and published a new release.
Hopefully this will unblock some people.

Sorry for the wait.. I was in Iceland.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants