Fix duplicated hk time bin bug #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samaloney
commented
Jan 30, 2024
samaloney
commented
Jan 30, 2024
samaloney
commented
Jan 30, 2024
stixcore/time/datetime.py
Outdated
| @@ -446,6 +452,15 @@ def to_datetime(self): | |||
| except TypeError: | |||
| utc = Spice.instance.scet_to_datetime(self.to_string()) | |||
|
|
|||
| kernel_name = Spice.instance.meta_kernel_path[1].name.split('_')[4] | |||
There was a problem hiding this comment.
We really shouldn't use any time conversations in the future compared to the meta kernel date as they are subject to change especially for science data!
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #379 +/- ##
==========================================
+ Coverage 76.80% 77.08% +0.27%
==========================================
Files 66 66
Lines 6912 6907 -5
==========================================
+ Hits 5309 5324 +15
+ Misses 1603 1583 -20 ☔ View full report in Codecov by Sentry. |
samaloney
force-pushed
the
bugfix-hk-times
branch
from
50ca833
to
9562d95
Compare
nicHoch
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.