Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Fails #191

Closed
purplepoet01 opened this issue Apr 30, 2022 · 7 comments
Closed

Restore Fails #191

purplepoet01 opened this issue Apr 30, 2022 · 7 comments

Comments

@purplepoet01
Copy link

Every time I try to restore a saved file, the site tells me restore failed. Not sure why.

@angstsmurf
Copy link
Contributor

Thanks for reporting this! Which site is it you are playing on?

@whatwhatwhatwhatwoahhh
Copy link

whatwhatwhatwhatwoahhh commented Jul 29, 2022

@angstsmurf
Copy link
Contributor

Thanks!

I can't reproduce this, but I had problems in the past running out of disk space quota when running this in a browser.

What browser and OS is this? Did it happen the first time you tried to restore or did it use to work? Do you have a lot of saved positions?

@curiousdannii
Copy link
Member

curiousdannii commented Jul 29, 2022

I can reproduce it, and there are improvements we can make to Parchment, but there's probably not really much to do on the CM side. The only thing would be to patch the save code to check for 0 bytes being written.

I wrote more at https://intfiction.org/t/counterfeit-monkey-restoring-fails-in-parchment/57013/2

@curiousdannii
Copy link
Member

I have made it so that Parchment now encodes files in base32768 for localStorage, so you should be able to store about 7 times more data there now. This is live on iplayif.com and from what I can see everything is working properly. Let me know if you see any bugs.

I haven’t made it delete old autosaves, but I intend to look at that soon.

@curiousdannii
Copy link
Member

@angstsmurf You could look at bringing in this code into CM, it should work in 6M62: ganelson/inform#64

@angstsmurf
Copy link
Contributor

I incorporated your fix. It would be nice if somebody could confirm that it is working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants