Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship Release 11 #196

Closed
dfabulich opened this issue Jan 27, 2023 · 11 comments
Closed

Ship Release 11 #196

dfabulich opened this issue Jan 27, 2023 · 11 comments

Comments

@dfabulich
Copy link
Collaborator

There's been quite a bit of work done in this repository since Release 10 in March 2021. (I'm particularly enthusiastic to ship mobile-friendliness enhancements.)

@angstsmurf
Copy link
Contributor

Sure. What does @emshortif think?

@emshortif
Copy link

emshortif commented Feb 1, 2023 via email

@angstsmurf
Copy link
Contributor

Haven't heard a lot from the team lately. Does @i7/counterfeit-monkey feel it’s ready to go?

@dfabulich
Copy link
Collaborator Author

If you have a pre release build, I’d be happy to run through it.

@angstsmurf
Copy link
Contributor

Here you go: Pre-release build.

@dfabulich
Copy link
Collaborator Author

dfabulich commented Feb 2, 2023

I deleted my ~/Library/Containers/net.ccxvii.spatterlight/Data/Library/Application Support/Spatterlight/Gluxe Files folder (including monkeyac.glkdata) and started a fresh game of Counterfeit Monkey with the pre-release build. I then played through the whole game, unlocking all achievements, with highlighting on, using exclusively the new remove X from Y syntax for letter removal.

I successfully saved and restored, no problem (#191) and I restarted without issue (#187)

#181 wasn't fixed.
We missed a spot in #184.

I also filed a few new issues: #195 #197 #198 #199 #200 #201. Of those, I think only #199 and perhaps #201 really ought to be fixed before release; the others could let slide. (But I'd especially love it if #195 were implemented.)

Also, I was really hoping that this version would be highly playable on Parchment for iPhone, thanks to the fix for #186, but when I tried it, I found curiousdannii/parchment#134 That's a real bummer, but it may not make sense to try to fix that before shipping Release 11. (It's not even clear to me whether we should treat this as a bug in Parchment or Counterfeit Monkey or what.)

@angstsmurf
Copy link
Contributor

I think all the important stuff is implemented now. Another pre-release testing version: https://github.com/i7/counterfeit-monkey/releases/download/r11b/CounterfeitMonkey-11b-pre.gblorb

@dfabulich
Copy link
Collaborator Author

I did a quick run through. #181 is now fixed. #199 is not fixed… it appears unchanged.

How do you feel about #197? And while I recognize that #195 might be a lot, I also suggested a text change, which I've now filed separately as #202. Could we do #202, even if we're not doing #195??

@dfabulich
Copy link
Collaborator Author

(Might I request permissions to reopen issues on this repository?)

@angstsmurf
Copy link
Contributor

You'd have to ask @curiousdannii. I don't have admin privileges here, or whatever the correct term is.

@curiousdannii
Copy link
Member

Think I've given you permission now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants