Skip to content

Commit

Permalink
changes from CodeReview question
Browse files Browse the repository at this point in the history
[Question on CodeReview.StackExchange web-site](https://codereview.stackexchange.com/questions/166613/news-site-scraping/166632?noredirect=1#comment317524_166632)
list of changes:
* add more docstrings
* fix hash comments
* fix some functions
* renamings:
    * `_protocol` field to `_scheme`
    * `EventItem` to `ArticleItem`
  • Loading branch information
iAnanich committed Jun 27, 2017
1 parent 6fa9bfb commit cee2bc2
Show file tree
Hide file tree
Showing 4 changed files with 241 additions and 87 deletions.
4 changes: 2 additions & 2 deletions scrapy_climate/items.py
Expand Up @@ -8,12 +8,12 @@
import scrapy


class EventItem(scrapy.Item):
class ArticleItem(scrapy.Item):
header = scrapy.Field()
tags = scrapy.Field()
url = scrapy.Field()
text = scrapy.Field()
video = scrapy.Field()
phoro = scrapy.Field()
photo = scrapy.Field()

index = scrapy.Field()
4 changes: 2 additions & 2 deletions scrapy_climate/pipelines.py
Expand Up @@ -10,7 +10,7 @@
import scrapy

from .args import options
from .items import EventItem
from .items import ArticleItem
from .storage import StorageMaster, StorageSession


Expand All @@ -27,7 +27,7 @@ def close_spider(self, spider: scrapy.spiders.Spider):
self.storage_session.close_session()

def process_item(self, item: scrapy.item.Item, spider: scrapy.spiders.Spider):
if isinstance(item, EventItem):
if isinstance(item, ArticleItem):
self.storage_session.append_item(item)
return item
else:
Expand Down

0 comments on commit cee2bc2

Please sign in to comment.