Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon-only <IconButton> #15

Merged
merged 9 commits into from
Apr 7, 2017
Merged

Icon-only <IconButton> #15

merged 9 commits into from
Apr 7, 2017

Conversation

zhusee2
Copy link
Contributor

@zhusee2 zhusee2 commented Apr 5, 2017

Purpose

Provide an icon-only <Button> which displays status icon on the icon.

Implement

  1. Fix <Button>:
  • should be exposed to bundle via index.js
  • should turn red on error state
  1. Add <IconLayout> for placing status icon above an <Icon>
  2. Add <IconButton> as a custom-configured variant of <Button>

Notes

<Tooltip> will be implemented in next PR.

Virtual Structure

<IconButton icon="printer" status="loading">
    <Button status="loading">
        <IconLayout icon="printer">
            <Icon type="printer" />
            <StatusIcon status="loading" />
        </IconLayout>
    </Button>
</IconButton>

Demo

2017-04-05 12 13 51

@zhusee2 zhusee2 changed the title Feature/zhusee icon button con button Apr 5, 2017
@zhusee2 zhusee2 changed the title con button Icon-only <IconButton> Apr 5, 2017
@zhusee2 zhusee2 requested review from paizanmay and cjies April 5, 2017 04:27
Copy link
Contributor

@cjies cjies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go 👍

Copy link

@paizanmay paizanmay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COOL~~

@zhusee2 zhusee2 merged commit 51fd593 into develop Apr 7, 2017
@zhusee2 zhusee2 deleted the feature/zhusee_icon_button branch April 7, 2017 08:23
@zhusee2 zhusee2 restored the feature/zhusee_icon_button branch April 7, 2017 08:23
@zhusee2 zhusee2 deleted the feature/zhusee_icon_button branch April 7, 2017 08:23
@zhusee2 zhusee2 mentioned this pull request Apr 17, 2017
@zhusee2 zhusee2 mentioned this pull request May 24, 2017
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants