Add Checkbox and icon-only Checkbox #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhusee2
force-pushed
the
feature/zhusee_checkbox
branch
from
4a8095e
to
f12b01b
Compare
zhusee2
force-pushed
the
feature/zhusee_checkbox
branch
from
b208c90
to
dc3ee63
Compare
cjies
suggested changes
Apr 26, 2017
| iconWrapper: ROOT_BEM.element('icon-wrapper'), | ||
| }; | ||
|
|
||
| export const CHECKBOX_BUTTON = <Icon type="empty" className={`${BEM.button}`} />; |
There was a problem hiding this comment.
component 我還是建議用駝峰命名 XD <CheckboxButton>
There was a problem hiding this comment.
因為他不是 component XD
他只是一個變數，存著預先定義好的 element?
There was a problem hiding this comment.
當然做成這樣也可以啦
function CheckboxButton() {
return <Icon type="empty" className={`${BEM.button}`} />;
}只是就覺得好像沒有這個必要
There was a problem hiding this comment.
不太建議轉成 function
🤔 🤔 🤔 沒關係就保留原本的吧
cjies
reviewed
Apr 26, 2017
|
|
||
| const srcPath = path.resolve(__dirname, '..'); | ||
|
|
||
| describe('Gypcrete Bundle', () => { |
|
others LGTM |
cjies
approved these changes
Apr 26, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add normal
<Checkbox>and icon-only<IconCheckbox>.Implement
<Checkbox>withindeterminatesupport and clean layout<IconCheckbox>to override checkbox button and make component minified./index.jsto check if every component is proper exported.Demo