-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Checkbox and icon-only Checkbox #27
Conversation
4a8095e
to
f12b01b
Compare
b208c90
to
dc3ee63
Compare
iconWrapper: ROOT_BEM.element('icon-wrapper'), | ||
}; | ||
|
||
export const CHECKBOX_BUTTON = <Icon type="empty" className={`${BEM.button}`} />; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
component 我還是建議用駝峰命名 XD <CheckboxButton>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
因為他不是 component XD
他只是一個變數,存著預先定義好的 element?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
當然做成這樣也可以啦
function CheckboxButton() {
return <Icon type="empty" className={`${BEM.button}`} />;
}
只是就覺得好像沒有這個必要
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不太建議轉成 function
🤔 🤔 🤔 沒關係就保留原本的吧
|
||
const srcPath = path.resolve(__dirname, '..'); | ||
|
||
describe('Gypcrete Bundle', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍 👍
others LGTM |
Purpose
Add normal
<Checkbox>
and icon-only<IconCheckbox>
.Implement
<Checkbox>
withindeterminate
support and clean layout<IconCheckbox>
to override checkbox button and make component minified./index.js
to check if every component is proper exported.Demo