Add <Switch> #37
Merged
Add <Switch> #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjies
reviewed
May 9, 2017
src/Switch.js
Outdated
| */ | ||
| input: PropTypes.object, // eslint-disable-line react/forbid-prop-types | ||
| turnedOn: PropTypes.bool, | ||
| defaultTurnedOn: PropTypes.bool, |
There was a problem hiding this comment.
我還是比較偏向 checkbox 的 checked 和 defaultChecked,
turnedOn 我覺得會沒這麼直覺，如果沒看文件的話會一時不知道要怎麼使用 XD
cjies
approved these changes
May 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Migrate row component
<Switch>Implement
<SwitchIcon>which assembles the appearance of an iOS switch, and should be used as a 64x32 icon.<Switch>to integrate<SwitchIcon>into a row component layout.<IconLayout>so it can turn off tooltips.Demo