-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate components (1st batch) #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .scss
files should placed in src/sass
or src/scss
folder? 🤔
doc/DocApp.js
Outdated
@@ -1,8 +1,14 @@ | |||
import React from 'react'; | |||
import App from '../src'; | |||
import '../src/css/index.scss'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add src
and doc
as the aliases in webpack to resolve their paths.
webpackBaseConfig = {
resolve: {
alias: {
src: path.resolve(__dirname, '../src'),
doc: path.resolve(__dirname, '../doc')
}
}
}
src/css/Icon.scss
Outdated
@@ -0,0 +1,208 @@ | |||
@import "./animations"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just take a note here.
If we import the resources that will be actually rendered in CSS, it will be added to every imported SASS file. Maybe we can try cssnano to discard the duplicated parts.
But this suggestion is not the main scope of this PR, I will open a PR to fix this problem later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or I can simply move them to index.scss
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's is a good idea 👍
Regarding the naming of stylesheets folder: I think I'll just pick |
affc35f
to
b557b5e
Compare
Post-review changes
|
Purpose
Migrate components from iC-framework-react.
Components
📦
<Tag>
📦
<Icon>
📦
<TextEllipsis>
📦
<StatusIcon>
(slightly modified)📦
<FlexCell>
(slightly modified)Other implements
file-loader
Demo