Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zIndex prop to renderToLayer HOC #409

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

chenesan
Copy link
Contributor

@chenesan chenesan commented Sep 1, 2023

Purpose

To enable adjusting zIndex of base layer of <Popup /> or <Popover />, added zIndex prop on renderToLayer HOC.

Changes

  • a list of what have been done
  • maybe some code change

Risk

Usually none, if you have any please write it here.

TODOs

  • Describe what should be done outside of this PR
  • Maybe in other PRs or some manual actions.

@chenesan chenesan self-assigned this Sep 1, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot temporarily deployed to canary September 1, 2023 09:14 Inactive
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #409 (8dc8de2) into develop (b9d0b0e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #409      +/-   ##
===========================================
+ Coverage    88.43%   88.45%   +0.02%     
===========================================
  Files          151      151              
  Lines         1539     1542       +3     
  Branches       281      283       +2     
===========================================
+ Hits          1361     1364       +3     
  Misses         178      178              
Files Changed Coverage Δ
packages/core/src/mixins/renderToLayer.js 100.00% <100.00%> (ø)

@chenesan chenesan marked this pull request as ready for review September 1, 2023 09:32
@chenesan chenesan merged commit 011922d into develop Sep 5, 2023
13 checks passed
@chenesan chenesan deleted the feature/add_zindex_prop_on_render_to_layer branch September 5, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants