-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create <TextInput> row component #41
Conversation
examples/TextInput/BasicUsage.js
Outdated
</DebugBox> | ||
|
||
<DebugBox> | ||
<TextInput value="Controlled input" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
controlled input should contain onChange
in example ? XD
|
||
<DebugBox> | ||
<TextInput | ||
value="Kitchen Printer" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here also.
主要是避免 console 會噴奇怪的 warning XD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others LGTM
這邊的問題是: 為了讓 |
不過我還是補一下 |
Purpose
Create
<TextInput>
which renders the pre-configured<EditableText>
instead of basic<Text>
generated byrowComp()
mixin.Implement
<TextInput>
which renders and pass whitelisted props to an<EditableText>
inside.getTextLayoutProps()
helper inrowComp()
so components can have the same text layout logic as a regularrowComp()
component.<TextInput>
.Demo