-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Refactor SelectRow component to use React hooks #418
Merged
kyoyadmoon
merged 5 commits into
project/upgrade-react-v18
from
refactor/remove-unsafe-lifecycles-part3
Dec 19, 2023
Merged
refactor: Refactor SelectRow component to use React hooks #418
kyoyadmoon
merged 5 commits into
project/upgrade-react-v18
from
refactor/remove-unsafe-lifecycles-part3
Dec 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## refactor/remove-unsafe-lifecycles-part2 #418 +/- ##
===========================================================================
- Coverage 88.22% 88.19% -0.04%
===========================================================================
Files 151 151
Lines 1597 1601 +4
Branches 279 278 -1
===========================================================================
+ Hits 1409 1412 +3
- Misses 188 189 +1
|
chenesan
approved these changes
Dec 18, 2023
b768ece
to
36b8195
Compare
|
Base automatically changed from
refactor/remove-unsafe-lifecycles-part2
to
project/upgrade-react-v18
December 19, 2023 05:47
Orcus2021
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose