Error installing frida on Android

[matbrik]

Hi, I tried to automatically install frida on the device but it seems not working
I've tried on a Nexus 5 with 5.1 and on a Pixel XL with android 8 rooted with Magisk from Ubuntu
my steps are:
I start Dwarf
select Android
A dwarf USB session window opens with a red bar saying waiting for device and a button install frida
I click on install frida, a series of messages appear
once done on the red bar appears a dropdown menu with 2 entries of Pixel XL
If I try again Install frida more pixel xl entries appear in the dropdown menu
I checked on the device and frida is not running nor installed

[matbrik]

I manually copied the frida binary in /data/local/tmp/ and modified the commands to frida in adb from frida to /data/local/tmp/frida and now it shows correctly the processes and the apps

[PinkiePieStyle]

should be fixed with
45b2f03

[matbrik]

with the new commit on the terminal which started dwarf once I click the button "install frida" I get "failed to mount /system on device" and the red bar stays hanging with the label "Mounting devices filesystem..."

[PinkiePieStyle]

make sure in magisk->superuser 'shell' is enabled

[matbrik]

yes it is

[PinkiePieStyle]

whats the output when u run
adb shell "mount | grep system"
in console

[matbrik]

/dev/block/sda34 on /system_root type ext4 (ro,seclabel,relatime,data=ordered)
/dev/block/sda34 on /system type ext4 (ro,seclabel,relatime,data=ordered)
/sbin/.magisk/block/system_root on /sbin/.magisk/mirror/system_root type ext4 (ro,seclabel,relatime,data=ordered)

[PinkiePieStyle]

ok so
adb root
adb remount
should work

[PinkiePieStyle]

or u can try changing in lib/adb.py
line 390
from
res = self.su_cmd('mount -o rw,remount /system')
to
res = self.su_cmd('mount -o rw,remount /dev/block/sda34 /system')

[matbrik]

same error with res = self.su_cmd('mount -o rw,remount /dev/block/sda34 /system')
also adb root does not work because

adbd cannot run as root in production builds

[iGio90]

Whats the output of
adb shell su -c getenforce
adb shell su -c mount -o rw,remount /system

[matbrik]

adb shell su -c getenforce --> Enforcing
adb shell su -c mount -o rw,remount /system --> blank line

[iGio90]

blank line means success.

adb shell su -c setenforce 0
(Just to be sure)

[iGio90]

Try to
adb shell
su
echo test >> /system/xbin/testtttt
rm /system/xbin/testtttt

If it works you can safely copy frida there and chmod a+x it

[matbrik]

adb shell
marlin:/ $ su
marlin:/ # echo test >> /system/xbin/testtttt
/system/bin/sh: can't create /system/xbin/testtttt: No such file or directory

there is no xbin folder in /system/
side question: why are you installing frida in system and not in /data/local/tmp/ ?