added yarn.lock #10
Merged
added yarn.lock #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sschadwick, you can make a proposal for the documentation. Thank you |
|
Added documentation on yarn per #9 |
iGitScor
requested changes
Oct 15, 2016
| @@ -6,10 +6,10 @@ A real-time culture sharer using Firebase as its backend and AngularJS on the fr | |||
| ## Installation | |||
|
|
|||
| # Install global NPM dependencies: | |||
| npm install -g gulp bower jshint recess | |||
| npm install -g gulp bower jshint recess yarn | |||
There was a problem hiding this comment.
https://github.com/yarnpkg/yarn is not a npm package. Could you modify your pull request please ?
|
Waiting for the change request. After modification, the pull request will can be merged |
|
Works fine through npm. |
|
@sschadwick your pull request works fine, but an issue (yarnpkg/yarn#616) with yarn and bower make it not working correctly Linked to #12 proposal: remove bower from the project |
iGitScor
approved these changes
Oct 19, 2016
iGitScor
added
Workflow: do not merge
Workflow: pending
and removed
Workflow: do not merge
Workflow: pending
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve half of #9. Please let me know if you want me to add documentation (re: Two contributors required)