Merge pull request #122 from iKonoTelecomunicaciones/121-fix-set-exte…

…rnal-variables-endpoint-response fix(api): 🐛 Fixed set external variables endpoint
iKonoTelecomunicaciones · Jun 6, 2024 · 318028e · 318028e
2 parents e23f3f5 + 998af78
commit 318028e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/menuflow/api/__init__.py b/menuflow/api/__init__.py
@@ -22,7 +22,7 @@ def init(cfg: Config, loop: AbstractEventLoop) -> web.Application:
                 allow_credentials=True,
                 expose_headers="*",
                 allow_headers="*",
-                allow_methods=["GET", "POST", "OPTIONS", "PATCH"],
+                allow_methods=["GET", "POST", "OPTIONS", "PATCH", "PUT"],
             )
         },
     )

diff --git a/menuflow/api/client.py b/menuflow/api/client.py
@@ -101,7 +101,7 @@ async def set_variables(request: web.Request) -> web.Response:
 
     await room.set_variable(variable_id="external", value=variables)
 
-    return resp.ok
+    return resp.ok({"detail": {"message": "Variables set successfully"}})
 
 
 # Update or create new flow

diff --git a/menuflow/nodes/http_request.py b/menuflow/nodes/http_request.py
@@ -137,6 +137,9 @@ async def make_request(self):
             f"node: {self.id} method: {self.method} url: {self.url} status: {response.status}"
         )
 
+        if response.status >= 400:
+            self.log.debug(f"Response: {await response.text()}")
+
         if response.status == 401:
             o_connection = None
             if not self.middleware:
@@ -230,12 +233,11 @@ async def run_middleware(self, status: int):
                 {
                     self.room.room_id: {
                         "last_http_node": self.id,
-                        "attempts_count": self.HTTP_ATTEMPTS.get(self.room.room_id, {}).get(
-                            "attempts_count"
-                        )
-                        + 1
-                        if self.HTTP_ATTEMPTS.get(self.room.room_id)
-                        else 1,
+                        "attempts_count": (
+                            self.HTTP_ATTEMPTS.get(self.room.room_id, {}).get("attempts_count") + 1
+                            if self.HTTP_ATTEMPTS.get(self.room.room_id)
+                            else 1
+                        ),
                     }
                 }
             )