optimisations #28
Merged
optimisations #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensure heap memory gets cleaned by using smart pointers
eleogran
reviewed
Dec 4, 2017
src/KDTrack.C
Outdated
| const double sPhi0 = sin(phi0); | ||
| const double ratio = (y0 - b) / (x0 - a); | ||
| const double ratio2 = ratio * ratio; | ||
| const double errorPhi0Denomitor = (1. / ((y0 - b) * (1 + (ratio2)))); |
eleogran
reviewed
Dec 4, 2017
| } catch (TooManyTracksException& e) { | ||
| streamlog_out(MESSAGE) << "caught too many tracks, tightening parameters" << std::endl; | ||
| caughtException = true; | ||
| factor -= 1; |
There was a problem hiding this comment.
how much is the reduction in number of tracks from factor = 10 to factor = 9? Isn't the -= 1 bin too fine?
There was a problem hiding this comment.
I will add a flag to disable the tightening of parameters, and if disabled directly skip the event.
eleogran
reviewed
Dec 4, 2017
src/KDTrack.C
Outdated
|
|
||
| double debugError2 = sqrt(deltaPhi * deltaPhi * errorRadC * errorRadC + errorDeltaPhi * errorDeltaPhi * radC * radC); | ||
| if (debug) | ||
| double debugError2 = sqrt(deltaPhi * deltaPhi * errorRadC * errorRadC + errorDeltaPhiSquared * radC * radC); |
There was a problem hiding this comment.
minor: since it is a sqrt, why is this named Error2?
There was a problem hiding this comment.
the name was there before, but I will rename it
…decreasing refCount
… used in debug only FIXME
andresailer
force-pushed
the
protectTheMem
branch
2 times, most recently
from
fe81137
to
69abf1f
Compare
…if there are too many tracks being created
andresailer
force-pushed
the
protectTheMem
branch
from
69abf1f
to
ef66dab
Compare
dhynds
approved these changes
Dec 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also AIDASoft/aidaTT#19
BEGINRELEASENOTES
ENDRELEASENOTES