Set the destructors to default and require an LCIO version

iLCSoft · Jan 18, 2024 · 5c63b8d · 5c63b8d
1 parent 52b59c7
commit 5c63b8d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -24,7 +24,7 @@ FIND_PACKAGE( ILCUTIL REQUIRED COMPONENTS ILCSOFT_CMAKE_MODULES ILCTEST )
 INCLUDE( ilcsoft_default_settings )
 
 
-FIND_PACKAGE( LCIO REQUIRED )
+FIND_PACKAGE( LCIO 2.20.1 REQUIRED )
 # export following variables to LCCDConfig.cmake
 SET( LCCD_DEPENDS_INCLUDE_DIRS ${LCIO_INCLUDE_DIRS} )
 SET( LCCD_DEPENDS_LIBRARY_DIRS ${LCIO_LIBRARY_DIRS} )

diff --git a/source/include/lccd_exceptions.h b/source/include/lccd_exceptions.h
@@ -24,7 +24,7 @@ namespace lccd{
     LCCDException(){  /*no_op*/ ; } 
 
   public: 
-    virtual ~LCCDException() noexcept { /*no_op*/; }
+    virtual ~LCCDException() noexcept = default;
 
     LCCDException( const std::string& text ) {
       message = "lccd::Exception: " + text ;
@@ -42,7 +42,7 @@ namespace lccd{
   protected:
     DatabaseException() {  /*no_op*/ ; } 
   public: 
-    virtual ~DatabaseException() noexcept { /*no_op*/; }
+    virtual ~DatabaseException() noexcept = default;
 
     DatabaseException( std::string text ){
       message = "lccd::DatabaseException: " + text ;
@@ -56,7 +56,7 @@ namespace lccd{
   class DataNotAvailableException : public LCCDException{
 
   public: 
-    virtual ~DataNotAvailableException() noexcept { /*no_op*/; }
+    virtual ~DataNotAvailableException() noexcept = default;
 
     DataNotAvailableException( std::string text ) {
       message = "lccd::DataNotAvailableException: " + text ;
@@ -70,7 +70,7 @@ namespace lccd{
   class ReadOnlyException : public LCCDException{
 
   public: 
-    virtual ~ReadOnlyException() noexcept { /*no_op*/; }
+    virtual ~ReadOnlyException() noexcept = default;
 
     ReadOnlyException( std::string text ){
       message = "lccd::ReadOnlyException: " + text ;
@@ -84,7 +84,7 @@ namespace lccd{
   class InconsistencyException : public LCCDException{
 
   public: 
-    virtual ~InconsistencyException() noexcept { /*no_op*/; }
+    virtual ~InconsistencyException() noexcept = default;
 
     InconsistencyException( std::string text ) {
       message = "lccd::InconsistencyException: " + text ;
@@ -98,7 +98,7 @@ namespace lccd{
   class MemberNotImplementedException : public LCCDException{
 
   public: 
-    virtual ~MemberNotImplementedException() noexcept { /*no_op*/; }
+    virtual ~MemberNotImplementedException() noexcept = default;
 
     MemberNotImplementedException( std::string text ) {
       message = "lccd::MemberNotImplementedException: " + text ;