Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate C-API #137

Merged
merged 3 commits into from Oct 12, 2021
Merged

Deprecate C-API #137

merged 3 commits into from Oct 12, 2021

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented May 6, 2021

BEGINRELEASENOTES

  • Deprecate the C-API which is used by the fortran interface. However, since no one seems to be actively using that interface we introduce a deprecation warning for the C-API to see if that has any users outside of the internal fortran interface. If you are seeing deprecation messages in your build outputs please let us know.
  • Fix F77 tests and run them in the CI.
    • Degrade some compiler errors back to warnings for gcc10 as it has become more strict than previous versions.

ENDRELEASENOTES

The SimTrackerHitImpl::setCellID function does not exist in cpp, so it probably shouldn't exist for the fortran API either. Also added the non-deprecated lcsthgetcellid0 and lcsthgetcellid1 to the API (implementations were already present).

Remove function that is not present in cpp code and replace it with one
that is.
@tmadlener
Copy link
Contributor Author

Seems like gcc10 is a bit more stringent than previous versions:

Also there seem to be some additional warnings that are all similar to this one here: https://github.com/iLCSoft/LCIO/runs/2519286851?check_suite_focus=true#step:4:407

However, my limited fortran knowledge is not enough to have an idea of how to fix these.

@tmadlener tmadlener changed the title Fix fortran API and enable F77 tests in CI Deprecate C-API Jul 30, 2021
@andresailer
Copy link
Contributor

Isn't Whizard using the C API?

@tmadlener
Copy link
Contributor Author

From what we gathered, both Whizard and SGV implement/generate their own Fortran API for LCIO which does not use the C API.

@andresailer
Copy link
Contributor

Ok, thanks for the information!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants