fix(chat): 🐛 Change to line-based triggers for chat capture (#44) #47
+103
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving to line-based triggers for chat capture This addresses #4 but should be tested because improper line captures can cause Mudlet to crash. Also, I am currently getting a strange echo of chats and events, which seems to be server-related, but I can't be sure.
|
Closes #4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving to line-based triggers for chat capture
This addresses #4 and was tested for a week. Initially it there was mudlet crash potential and strange echo of chats and events, which seem to have been server-related and absolved after changes to GA on server side.