Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix how the unit of measurement is retrieved #177

Merged
merged 5 commits into from
Jul 28, 2020
Merged

Fix how the unit of measurement is retrieved #177

merged 5 commits into from
Jul 28, 2020

Conversation

tetienne
Copy link
Collaborator

@tetienne tetienne commented Jul 27, 2020 •
edited
Loading

@github-actions github-actions bot added the bug Something isn't working label Jul 27, 2020
@tetienne
Copy link
Collaborator Author

Need to add m3. See https://github.com/redbug26/jeedom-tahoma/blob/6e53512c562ad980f83708313d602db1c05d844e/core/class/tahoma.class.php#L395

iMicknl
iMicknl requested changes Jul 27, 2020
View reviewed changes
Copy link
Owner

@iMicknl iMicknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CONCENTRATION_PARTS_PER_MILLION is missing, for the following sensors. Do they also have an attribute?

io:CO2IOSystemDeviceSensor
io:CO2IOSystemSensor
io:COIOSystemSensor

@tetienne
Copy link
Collaborator Author

CONCENTRATION_PARTS_PER_MILLION is missing, for the following sensors. Do they also have an attribute?

io:CO2IOSystemDeviceSensor
io:CO2IOSystemSensor
io:COIOSystemSensor

Sadly, I was not able to find any setup exemple with such exemple. I can ask on HA forum.

@tetienne tetienne merged commit b9406bc into master Jul 28, 2020
@tetienne tetienne deleted the fix/sensor_unit branch July 28, 2020 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iMicknl iMicknl iMicknl approved these changes

@vlebourl vlebourl Awaiting requested review from vlebourl vlebourl is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tetienne @iMicknl @vlebourl