Group entities by physical device

[iMicknl]

Functionality from #328 by @vlebourl

[iMicknl]

@vlebourl could you give this a try? I don't have any devices that have multiple entities...

[vlebourl]

@vlebourl could you give this a try? I don't have any devices that have multiple entities...

I'll try that tomorrow! But looks good to me.

[vlebourl]

that works for me!

[iMicknl]

@vlebourl I see that I need to copy the device info as well, looks like it is now displaying the last one.

[vlebourl]

@vlebourl I see that I need to copy the device info as well, looks like it is now displaying the last one.

ohyeah... missed that one

[vlebourl]

@vlebourl I see that I need to copy the device info as well, looks like it is now displaying the last one.

ohyeah... missed that one

That's why somewhere I retrieve the base_url#1 label to get the device info.

[iMicknl]

@vlebourl I see that I need to copy the device info as well, looks like it is now displaying the last one.

ohyeah... missed that one

That's why somewhere I retrieve the base_url#1 label to get the device info.

Did this work in your previous PR?

[vlebourl]

hmm scratch that, that's actually the model part in the return of tahoma_device device_info. We could set it to name as well. Or find something else relevant.

[iMicknl]

@vlebourl we can pull model and firmware from our parent device (#1) as well. I am not able to test it, but what if we just leave it empty for devices not being #1? Could you try that if I add it to this pr?

[vlebourl]

only #1 info shows up now:

that's fine IMO

[vlebourl]

but firmware is wrong...

[iMicknl]

@vlebourl could you perhaps give the latest version a try? If this doesn't work, I am not sure how to solve it :-). It is hard to fix without having the device present.

[iMicknl]

While removing old branches, I came across #152. Was this simple approach not good enough? :D

[tetienne]

@iMicknl If I remember well, it was because the name of the device was not correct. But indeed, the amount of modification between this PR and mine are not the same at all :)
@lebourl how dit you solve this: https://github.com/iMicknl/ha-tahoma/pull/152/files#r455789429 ?

[iMicknl]

@iMicknl If I remember well, it was because the name of the device was not correct. But indeed, the amount of modification between this PR and mine are not the same at all :)

Ahh, that is indeed solved in this PR. The amount of code is indeed more, but it is not that much. Most of the code is around retrieving the entity id / name of the original device.

[iMicknl]

@vlebourl could you perhaps give this PR a try? I am not able to test it and would be good to check before merge.