Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use instance variable for name #532

Merged
merged 2 commits into from
Aug 16, 2021
Merged

Use instance variable for name #532

merged 2 commits into from
Aug 16, 2021

Conversation

tetienne
Copy link
Collaborator

Part of #503

iMicknl
iMicknl approved these changes Aug 16, 2021
View reviewed changes
Copy link
Owner

@iMicknl iMicknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assume it's tested and doesn't have any issues? 😉

@tetienne
Copy link
Collaborator Author

LGTM, assume it's tested and doesn't have any issues? 😉

Sure!

@tetienne tetienne merged commit d8d08b8 into master Aug 16, 2021
@tetienne tetienne deleted the refactor/attr/name branch August 16, 2021 11:19
@iMicknl iMicknl added the enhancement New feature or request label Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iMicknl iMicknl iMicknl approved these changes

@vlebourl vlebourl Awaiting requested review from vlebourl vlebourl is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tetienne @iMicknl