Drop support for Python 3.8 & 3.9, add support for Python 3.12 in CI/CD and update to latest packages #1311
Conversation
iMicknl
force-pushed
the
enhancement/python_3_12
branch
from
f707b3d
to
1b2ce76
Compare
iMicknl
changed the title
|
@tetienne quite a big PR in the end. If you would have time coming week to have a quick glance, would be appreciated. I will do some tests on HA with this package, since there have been some (potential) breaking changes. |
Sure I will have a look. From my phone, it looks almost good. |
| @@ -9,6 +9,11 @@ on: | |||
| jobs: | |||
| deploy: | |||
| runs-on: ubuntu-latest | |||
| environment: release | |||
There was a problem hiding this comment.
We are not using the environment. We can remove this IMO.
There was a problem hiding this comment.
@tetienne we need this actually for the connection to PyPi. They are tied to an environment.
| @@ -31,10 +36,8 @@ jobs: | |||
| ref: "main" | |||
| env: | |||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |||
| - name: Build and publish to PyPi | |||
| env: | |||
| POETRY_PYPI_TOKEN_PYPI: ${{ secrets.PYPI_API_TOKEN }} | |||
There was a problem hiding this comment.
Once the new release process confirmed, don't forget to remove the secret.
By the way, I really like this news trusted publishing :)
| @@ -114,16 +114,16 @@ class OverkizClient: | |||
| _refresh_token: str | None = None | |||
| _expires_in: datetime.datetime | None = None | |||
| _access_token: str | None = None | |||
| _ssl_context: ssl.SSLContext | None = None | |||
| _ssl: ssl.SSLContext | bool = True | |||
There was a problem hiding this comment.
Should we include this as breaking change?
There was a problem hiding this comment.
It is a private setter so technically not a breaking change, but good to mention it. Here I am most afraid of breaking anything by the way, so will need to do proper testing before adding to HA.
Co-authored-by: Thibaut <thibaut@etienne.pw>
iMicknl
force-pushed
the
enhancement/python_3_12
branch
from
90041d6
to
f9734d5
Compare
This pull request includes multiple changes aimed at updating dependencies, improving type hints, and removing outdated configurations. The most important changes include updating the Python version, enhancing type hints, and cleaning up IntelliJ IDEA project files.
Breaking
Dependency and Version Updates:
.devcontainer/devcontainer.json: Updated the Docker image tomcr.microsoft.com/devcontainers/python:1-3.12-bullseyefor Python 3.12..github/workflows/main.yaml: Updated the Python versions in the matrix to include 3.12 and removed 3.8 and 3.9..python-version: Updated the Python version to 3.12.pyproject.toml: Updated dependencies and Python version requirements to>=3.10,<4.0.Type Hint Improvements:
pyoverkiz/client.py: Changed_ssl_contextto_ssland updated type hints for SSL context and verification. [1] [2] [3] [4] [5]pyoverkiz/models.py: Updated imports to usecollections.abcforIterator.pyoverkiz/types.py: Updated type hints to usecollections.abcforCallableand modernizedStateTypeandJSONdefinitions. [1] [2]Configuration Cleanup:
.idea/inspectionProfiles/Project_Default.xml,.idea/inspectionProfiles/profiles_settings.xml,.idea/misc.xml,.idea/modules.xml,.idea/python-tahoma-api.iml, and.idea/vcs.xml. [1] [2] [3] [4] [5] [6]Pre-commit and Tox Configuration:
.pre-commit-config.yaml: Updatedpre-commit-hookstov4.6.0and changedpyupgradearguments to--py310-plus. [1] [2]tox.ini: Updatedenvlistto include Python 3.12 and removed 3.8 and 3.9. [1] [2]Miscellaneous:
.github/CODEOWNERS: Removed@vlebourlfrom the list of code owners..github/release-drafter.yml: Added an empty line for better formatting.tests/test_client.py: Updated fixtures to be asynchronous. [1] [2]