Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional Betaflight rates #5209

Closed
ianrmurphy opened this issue Nov 16, 2019 · 4 comments
Closed

Optional Betaflight rates #5209

ianrmurphy opened this issue Nov 16, 2019 · 4 comments

Comments

@ianrmurphy
Copy link

Current Behaviour

iNav in Acro (rate) mode has it's own rate calculation which does not match that of Betaflight.

Desired Behaviour

There should be an option to specify and use Betaflight rates.

Suggested Solution

Implement a cli parameter (suggest 'rates_type', allowed values INAV, BETAFLIGHT) to choose between iNav and Betaflight rate calculation of '_rc_rate' and '_srate'.

Who does this impact? Who is this for?

With the recent improvements to iNav perfomance on multirotors in Acro (rate) mode there will be users who wish to switch from Betaflight to iNav. These users may have carefully tuned Betaflight rates which they wish to port over to get a consistent flying experience.

Additional context

Betaflight cli parameter 'rates_type', allowed values: BETAFLIGHT, RACEFLIGHT, KISS.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label Feature request to this issue, with a confidence of 0.93. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@ianrmurphy
Copy link
Author

Having made some small contributions to Betaflight I am happy to work on this feature. Would appreciate some guidance on the iNav features roadmap and iNav pull request etiquette.

@DzikuVx
Copy link
Member

DzikuVx commented Dec 24, 2019

I honestly think Betaflight rates are one of the worse rates ever. Being unitless with this mix of rates, rc rates and super rates it's counterintuitive and hard to setup. INAV deliberately moved out of those into degrees per second

@DzikuVx DzikuVx closed this as completed Dec 24, 2019
@chronowarper
Copy link

chronowarper commented Nov 11, 2023

Would you consider adding an option to use the rate curve from this PR on arducopter? It uses the Betaflight super rates for the expo calculation and uses deg/s as end-point.

ArduPilot/ardupilot#18689

Leonard has some analysis of the formula in my original PR (which was not implemented). I personally have found it difficult to replicate the same curve with inav with just endpoint and one expo curve.

ArduPilot/ardupilot#18667

With this, it's possible for someone flying acro to keep the same muscle memory cross arducopter/betaflight/inav.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants