DJI O3 - ON-HR and FLY-HR are availabe and can be added to replace questionmarks

[dzaro-dev]

As seen in the image below, BF_SYM_ON_H and BF_SYM_FLY_H are availabe and don't need to be questionmarks.

Original:

[mmosca]

Do not change values of BF_SYM entries. They are a mirror of betaflight values.

[dzaro-dev]

I see what you mean, but I think there must be a mistake in BTFL.

They surely have the on-hr and fly-hr symbols, but they have not used them anywhere in the code as far as I can see.

So could it be that BTFL has a mistake?

[dzaro-dev]

@mmosca Please reconsider opening the PR and have a look at this video that I made:

https://youtu.be/-O-JVKRkxbI

[mmosca]

Your example font does not match betaflight’s documentation. Those symbols don’t exist in betaflight.

[dzaro-dev]

[dzaro-dev]

@mmosca The BTFL documentation doen't matter in reality. What matters is DJI's fontset and where their icons are located.

[mmosca]

@mmosca The BTFL documentation doen't matter in reality. What matters is DJI's fontset and where their icons are located.

You are wrong there. Betaflight documentation is the source of truth for what symbols are. If DJI has an issue even with the betaflight font, INAV will not follow DJI’s version, as one day, DJI may fix it and it will break INAV.

Negative. This is the betaflight compatibility layer. Betaflight is the source of truth for what characters are available and what they are. If dji has an issue in their version of the Betaflight font, the same issue is present when using betaflight and it is up to dji to fix it.

You are free to disagree and keep using your local changes, but INAV will follow the Betaflight definition of the Betaflight font.

[mmosca]

The source material used for this pr does not reflect the actual betaflight font.

[MrD-RC]

I've just been going through this and see the problem. About 5 years ago BetaFlight changed fonts. There are a couple of symbols that are different between the two versions. What makes things worse is that DJI picked and chose which parts of which version they wanted to use.

These are the differences

Character	Hex	BF 1 symbol	BF 2 symbol	DJI symbol
4	0x04	Up arrow	Home icon	Up arrow
10	0x0A	cross	cross	blank
37	0x25	Dash right	&	Dash right
38	0x26	Dash left	blank	Dash left
112	0x70	On Hr	dial with needle	On Hr
113	0x71	Fly Hr	Rotate	Fly Hr
114 - 116	0x72 - 0x74	right angled arrows	Crosshair	Crosshair
121	0x79	right angle arrow	blank	right angle arrow
123	0x7B	blank	LQ	blank
125	0x7D	blank	Km	blank
126	0x7E	crosshair	Miles	crosshair

My thoughts are that this whole BFCOMPAT mode works for DJI O3. There is no other reason for it to even exist. So really, it should use the font that is in the O3 goggles. It really should have been called DJICOMPAT mode, rather than BF. We should maximise what we can to make it better for those pilots. Out of all the differences in the fonts. The only changes that may have any merit are the on/fly hrs (0x70 & 0x71) and maybe the crosshair (0x72 - 0x74).

Here is a full comparison
BF vs BF vs DJI.xlsx

[MrD-RC]

@mmosca Please reconsider opening the PR and have a look at this video that I made:

https://youtu.be/-O-JVKRkxbI

You should really stop with these videos. They just antagonise and do not help your cause.