Updating all locations where DIRECTION was used instead of DECORATION #10037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrD-RC
requested changes
May 14, 2024
Comment on lines
93
to
99
|
|
||
| */ | ||
| case SYM_AH_DECORATION_UP: | ||
| return BF_SYM_AH_DECORATION_UP; | ||
| return BF_SYM_ARROW_SMALL_UP; | ||
|
|
||
| case SYM_AH_DECORATION_DOWN: | ||
| return BF_SYM_AH_DECORATION_DOWN; | ||
| */ | ||
| return BF_SYM_ARROW_SMALL_DOWN; | ||
|
|
There was a problem hiding this comment.
This should be a separate PR. As it is not in the original scope.
There was a problem hiding this comment.
@MrD-RC No problem, I'll make a separate PR for this one.
Is ti possible to remove these changes from this PR?
Sorry, I'm not very well versed in GitHub things.
There was a problem hiding this comment.
Just revert these highlighted changes in the file, save and create/push a new commit.
There was a problem hiding this comment.
Got it, thank you, will do now. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per @MrD-RC 's feedback in PR#10031, I've updated all the locations where either
SYM_AH_DIRECTION_UPorSYM_AH_DIRECTION_DOWNwere used to:SYM_AH_DECORATION_UPandSYM_AH_DECORATION_UP.I closed all the other PR's because this should be all under one PR and not separate ones.
This matches what is written in the the INAV Character Map.md and ensures that what is written there is also in the firmware code.
This also allowed the enabling of the direction scrolling arrows in
displayport_msp_bf_compat.cwhen using DJI O3, as symbols are available to replace those blanks.Hope this helps.