Added modeActivationConditions parameter group #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #endif | ||
| } | ||
| PG_REGISTER_ARR(modeActivationCondition_t, MAX_MODE_ACTIVATION_CONDITION_COUNT, modeActivationConditions, PG_MODE_ACTIVATION_PROFILE, 0); | ||
| PG_REGISTER(modeActivationOperatorConfig_t, modeActivationOperatorConfig, PG_MODE_ACTIVATION_OPERATOR_CONFIG, 0); |
There was a problem hiding this comment.
Is it wise to waste a whole PG to modeActivationOperatorConfig which is only used together with modeActivationConditions? Isn't it better to combine the two PGs?
There was a problem hiding this comment.
Yes, I sort of think that as well. Trouble is modeActivationCondition is an array, and so I wasn't sure how best to combine them. My general approach is to just get things working and not think too hard about getting it exactly right - that would considerably slow down the process.
Once all the PGs are done, I intend to go through them again making minor adjustments.
There are also some discussions to be had about what is in a profile and what is not - I've also deferred that until they are all done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.