New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New feature: battery profiles #2749
New feature: battery profiles #2749
Conversation
I don't know why the checks failed the OMNIBUS target compiles fine on my machine. Well... I know why. GCC 7.1.0 seems better at optimizing the RAM usage. Are we already at the F3's limits !?
|
I disabled the external barometer support for OMNIBUS for the checks to pass. It is not necessary with the GCC version 7.1.0 but the OMNIBUS board has an on-board barometer so it is not needed anyway. |
Neat feature! Could be very nice to report, optionally, the current profile on the OSD via the system messages function before arming. |
@giacomo892 Good ideas. I thought about beeping the profile number it but I'm not familiar with how the beeper code is working yet I'll take a look at it. |
Would this be merged in 2.0 if I rebase this PR ? |
Why not?
…On Fri, Jun 8, 2018, 15:17 Michel Pastor ***@***.***> wrote:
Would this be merged in 2.0 if I rebase this PR ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2749 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AKi_m9QrTKjIaSd10ReVTAZ8OscyM4lZks5t6nlLgaJpZM4SBuFQ>
.
|
I'm asking because it was ready long before 1.9.1 so I was not sure why it was not merged earlier. I will rebase it. |
07257f4
to
5aa6b3b
Compare
Rebased and bench tested again. Ready to merge |
5aa6b3b
to
20c7b26
Compare
It would be nice to have a possibility to entirely disable the possibility to switch battery profiles via sticks (as we do to PID profiles) -to prevent accidental switching. |
20c7b26
to
7c3e113
Compare
7c3e113
to
1244376
Compare
Good idea. Battery profile selection is now only possible when the TX_PROF_SEL feature is enabled. I also updated the documentation. |
It would be a good idea to have a Scale and Offset current sensor set in each profile. |
@CpeDratDoPC I believe it's a voltage divider, it shouldn't change for hight voltages (maybe just be more precise). |
Feature request #2673
Summary
bat_cells
is 0 the cell count is calculated based onvbat_max_cell_voltage
Profile autoswitch
Automatic profile switching can be enabled with the
bat_profile_autoswitch
setting. The profile is chosen among profiles with number of cellsbat_cells
set to a value > 0. The automatically selected profile can be overridden if necessary with a stick command or through the CMS.Example config
Profile 1 is for a 3S Li-Po pack, profile 2 for a 3S Li-Ion pack and profile 3 for a 4S Li-Po pack.
With this configuration if the battery plugged in is less than 12.33V the profile 2 will be automatically selected else if the battery voltage is less than 12.63V the profile 1 will be automatically selected else if the battery voltage is less 16.84V the profile 3 will be automatically selected. If a matching profile can't be found the last manually selected profile is used.