Remove all MAX7456 specific code, replace it with generic interfaces #4384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiam
force-pushed
the
agh_remove_hardcoded_max7456
branch
3 times, most recently
from
96a1f9d
to
75da202
Compare
- Rename max7456_symbols.h to osd_symbols.h. We'll expect all supported OSD drivers to use the same font style. - Introduce drivers/osd.h, which defines the supported video systems and the format for the OSD characters that all drivers must support. - Remove drivers/vcd.h, since having a file for a single enum is kind of annoying, move this enum to the new drivers/osd.h file. - Add osdGetDisplayPort() for retriving the display port used by the OSD. - Add a new display function named writeFontCharacter() which takes a character address and its data. - Use the aforementioned 2 functions to implement character font uploading in fc_msp.c, so it's not MAX7456-specific anymore.
fiam
force-pushed
the
agh_remove_hardcoded_max7456
branch
from
75da202
to
9829ba4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSD drivers to use the same font style.
and the format for the OSD characters that all drivers must support.
kind of annoying, move this enum to the new drivers/osd.h file.
the OSD.
a character address and its data.
uploading in fc_msp.c, so it's not MAX7456-specific anymore.