Printf: Implement size checked and va_list variants #4683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfp_snprintf(), tfp_vsprintf() and tfp_vsnprintf Mark all the functions as accepting a format string. Also, drop the #define's for printf() and snprintf() and call them explicitely, since #defining printf messes up with __attribute__ ((format (printf, X, Y)))
Since the tfp_printf() functions now have format attributes, the format of the string has to match the arguments.
digitalentity
approved these changes
May 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Printf: Implement size checked and va_list variants
tfp_snprintf(), tfp_vsprintf() and tfp_vsnprintf
Mark all the functions as accepting a format string.
Also, drop the #define's for printf() and snprintf() and call
them explicitely, since #defining printf messes up with
attribute ((format (printf, X, Y)))
All: Fix warnings reported by -Wformat