Add icon to VTx power OSD element #7355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will the icon be present always? I ask because I have the OSD power number next to the home distance just to be aware if the power is autoswitching whenever its expected to and I appreciate it only needs one character position yet giving all information. Would appreciate to have the option to keep it as is. Thanks |
|
With the PR in its current state, it adds the symbol to the original OSD element. Maybe something in the CLI could be added to remove the symbol. Would that be acceptable. To me, numbers without symbols to show what they’re for are as useful as a chocolate teapot. But I can see that some people may want just the number. |
DzikuVx
approved these changes
Sep 8, 2021
|
i'd vote for selectable icon as well, i'd prefer to save osd space. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the VTx power just has a number, which isn't overly helpful. This PR, along with the configurator change (iNavFlight/inav-configurator#1331), will add a VTx power icon before the number.
Current OSD element:
VTx power is top centre of the AHI area
New OSD element: default font
New OSD element: impact mini font
@Jetrell, are you happy with the font?