Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mode availability improvements #7694

Merged
merged 6 commits into from Feb 8, 2022

Conversation

breadoven
Copy link
Collaborator

Cleans up mode availability based on craft type and sensors enabled.

SURFACE requirements need confirming (not sure if OPFLOW is required).

@DzikuVx DzikuVx added this to the 5.0 milestone Dec 27, 2021
@DzikuVx DzikuVx merged commit 47cb62a into iNavFlight:master Feb 8, 2022
@breadoven breadoven deleted the abo_fix_modes_craft_type branch April 8, 2022 07:24
@RipperGOT
Copy link

RipperGOT commented Jun 27, 2022

@breadoven For surface mode opflow it not requiered. I have a Benewake rangefinder mounted on my multi and works very well only with it.

I'm writing this to you because I just had a conversation on Discord after updating to 5.0 and seeing that the Surface in modes tab option doesn't appear. In 4.0 and 4.1 it works without problem!
We have come to the conclusion that the opflow was added to be able to use the Surface mode.

}
if (sensors(SENSOR_BARO) && sensors(SENSOR_RANGEFINDER) && sensors(SENSOR_OPFLOW)) {
ADD_ACTIVE_BOX(BOXSURFACE);

Could this be changed again so that only with Rangefinder the Surface mode can also be used? Thanks!!!!!

And sorry, I didn't see this before...

@breadoven
Copy link
Collaborator Author

No problem, I'll fix it. At least we now know what does work, I spent some time trying to work out what was required but it wasn't very obvious looking at available info.

@RipperGOT
Copy link

RipperGOT commented Jun 27, 2022

No problem, I'll fix it. At least we now know what does work, I spent some time trying to work out what was required but it wasn't very obvious looking at available info.

Thanks friend! I made the mistake of not realizing that the Surface mode did not appear when I tried RC1, 2 and 3.
When you do, and if you want, send me the test compiled firm, I'll be happy to test it! Baro and rangefinder are enough to get Surface mode working!

@breadoven
Copy link
Collaborator Author

No problem, I'll fix it. At least we now know what does work, I spent some time trying to work out what was required but it wasn't very obvious looking at available info.

Thanks friend! I made the mistake of not realizing that the Surface mode did not appear when I tried RC1, 2 and 3. When you do, and if you want, send me the test compiled firm, I'll be happy to test it!

The firmware should be available at https://github.com/iNavFlight/inav/actions/runs/2572191047 once it's finished testing.

@RipperGOT
Copy link

No problem, I'll fix it. At least we now know what does work, I spent some time trying to work out what was required but it wasn't very obvious looking at available info.

Thanks friend! I made the mistake of not realizing that the Surface mode did not appear when I tried RC1, 2 and 3. When you do, and if you want, send me the test compiled firm, I'll be happy to test it!

The firmware should be available at https://github.com/iNavFlight/inav/actions/runs/2572191047 once it's finished testing.

Thanks a lot!!!! If you need anything I can help you with, I'd be delighted! Less programming... I stayed in arduino and it wasn't very good either! 😅

@RipperGOT
Copy link

Sorry, where can I download Inav 6.0 configurator for test it???

@breadoven
Copy link
Collaborator Author

Oh forgot about that. You can get it here http://seyrsnys.myzen.co.uk/inav-configurator-next/.

@RipperGOT
Copy link

Perfect! Successfully detected! You're the best!

Captura de pantalla 2022-06-28 005026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants