Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE Support #7931

Merged
merged 9 commits into from Apr 12, 2022
Merged

BLE Support #7931

merged 9 commits into from Apr 12, 2022

Conversation

Scavanger
Copy link
Contributor

@Scavanger Scavanger commented Mar 27, 2022

Replaces #7783

@Scavanger Scavanger changed the title Ble BLE Support Mar 27, 2022
@stronnag
Copy link
Collaborator

This does not require an MSP version bump; we didn't do that for the introduction of MSP2.

@@ -534,18 +534,6 @@ static bool mspFcProcessOutCommand(uint16_t cmdMSP, sbuf_t *dst, mspPostProcessF
}
break;
#ifdef USE_PROGRAMMING_FRAMEWORK
case MSP2_INAV_LOGIC_CONDITIONS:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Scavanger this is a no-go. We can not change the current MSP frame to have a completely different structure.
Instead of changing MSP2_INAV_LOGIC_CONDITIONS let's do the following:

  1. Leave MSP2_INAV_LOGIC_CONDITIONS unchanged
  2. Add MSP2_INAV_LOGIC_CONDITIONS_SINGLE frame
  3. Switch configurator to use MSP2_INAV_LOGIC_CONDITIONS_SINGLE

@DzikuVx DzikuVx added this to the 5.0 milestone Apr 1, 2022
@DzikuVx DzikuVx merged commit 666f98e into iNavFlight:master Apr 12, 2022
@stronnag
Copy link
Collaborator

@Scavanger , couple of questions / comments.

  • cli_delay is ephemeral. It is not saved by CLI save. Is this deliberate, if so why? I think this will cause confusion.
  • In any case, why not a set paramer. Then it could be set from the configurator / MSP clients using MSP2_COMMON_SET_SETTING ?
  • cli_delay is useful for other use cases than BLE (e.g. dump works with GCC 11.2 compiled firmware, even if this is band-aid rather than a cure).

@Scavanger
Copy link
Contributor Author

@stronnag
cli_delay is only a workaround for some BLE adapters, it is not intended to be used by the user.
It makes no sense to save it, it would have to be reset when exiting CLI mode or the next CLI session would have to check again whether there is a BLE connection, otherwise the delay would be used unnecessarily, e.g. for a USB connection.
I think that would complicate everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants