New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary parameters from profiles #8451
Remove unnecessary parameters from profiles #8451
Conversation
`fw_loiter_direction` was in control profiles. There's no reason why this would want to be changed with different control parameters. It's purely a pilot preference. This has been moved to `navConfig.fw` 'fw_min_throttle_down_pitch` was in the battery profiles. This command is really something that is set based on the airframe and it's glide ratio. Battery type or performance does not effect this. Moved to `navConfig.fw`
Configurator changes for iNavFlight/inav#8451
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need PG version bump for all modified configs. Or we will be getting invalid settings when users upgrade without full chip erase
@DzikuVx Updated the PG. Think I need to get "Update PG" tattooed on my forehead 🤣 |
|
@shellixyz I don't think this is correct. a heavier battery raises the stall speed but also makes the glide faster at the same angle. only the aerodynamics of the plane dictate the glide angle. any real airplane has also a fixed glide ratio no matter if the fuel tanks are full or not. I just looked it up and indeed weight has no influence on the glide angle, only glide speed and therefore available glide time. |
Ok, you convinced me, it's fine to move it then |
fw_loiter_direction
was in control profiles. There's no reason why this would want to be changed with different control parameters. It's purely a pilot preference. This has been moved tonavConfig.fw
fw_min_throttle_down_pitch
was in the battery profiles. This command is really something that is set based on the airframe and it's glide ratio. Battery type or performance does not effect this. Moved tonavConfig.fw
Configurator iNavFlight/inav-configurator#1636