Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary parameters from profiles #8451

Merged
merged 4 commits into from Nov 27, 2022

Conversation

MrD-RC
Copy link
Collaborator

@MrD-RC MrD-RC commented Oct 6, 2022

fw_loiter_direction was in control profiles. There's no reason why this would want to be changed with different control parameters. It's purely a pilot preference. This has been moved to navConfig.fw

fw_min_throttle_down_pitch was in the battery profiles. This command is really something that is set based on the airframe and it's glide ratio. Battery type or performance does not effect this. Moved to navConfig.fw

Configurator iNavFlight/inav-configurator#1636

`fw_loiter_direction` was in control profiles. There's no reason why this would want to be changed with different control parameters. It's purely a pilot preference. This has been moved to `navConfig.fw`

'fw_min_throttle_down_pitch` was in the battery profiles. This command is really something that is set based on the airframe and it's glide ratio. Battery type or performance does not effect this. Moved to `navConfig.fw`
@MrD-RC MrD-RC added this to the 6.0 milestone Oct 6, 2022
MrD-RC added a commit to iNavFlight/inav-configurator that referenced this pull request Oct 6, 2022
@MrD-RC MrD-RC added Release Notes Add this when a PR needs to be mentioned in the release notes Requires Configurator and removed Release Notes Add this when a PR needs to be mentioned in the release notes labels Oct 6, 2022
Copy link
Member

@DzikuVx DzikuVx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need PG version bump for all modified configs. Or we will be getting invalid settings when users upgrade without full chip erase

@MrD-RC
Copy link
Collaborator Author

MrD-RC commented Oct 7, 2022

@DzikuVx Updated the PG. Think I need to get "Update PG" tattooed on my forehead 🤣

@MrD-RC MrD-RC requested a review from DzikuVx October 10, 2022 09:05
@shellixyz
Copy link
Collaborator

fw_min_throttle_down_pitch is in the battery profiles because you can use batteries which don't have the same weight and so need a different value for this setting

@b14ckyy
Copy link
Collaborator

b14ckyy commented Oct 15, 2022

@shellixyz I don't think this is correct.
the weight of the battery has no influence on the glide angle. only the glide speed but so does a lighter battery reduce the stall speed.

a heavier battery raises the stall speed but also makes the glide faster at the same angle.

only the aerodynamics of the plane dictate the glide angle. any real airplane has also a fixed glide ratio no matter if the fuel tanks are full or not.

I just looked it up and indeed weight has no influence on the glide angle, only glide speed and therefore available glide time.

https://skybrary.aero/articles/glide-performance

Screenshot_20221015-110023.png

@shellixyz
Copy link
Collaborator

@shellixyz I don't think this is correct. the weight of the battery has no influence on the glide angle. only the glide speed but so does a lighter battery reduce the stall speed.

Ok, you convinced me, it's fine to move it then

@MrD-RC MrD-RC merged commit 151798b into master Nov 27, 2022
@MrD-RC MrD-RC deleted the MrD_Remove-unneccesary-parameters-from-profiles branch November 27, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants