Increase number of voltage digits in BF compatibility mode OSD #8634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In BF compatible mode the . takes up space of data that usually gets displayed. It i possible to work around it for the main battery voltage by changing from 1 decimal digits to 2, but there will always only be space for N - 1 digits. This bumps the size of the field by 1 in BF_COMPATIBLE mode for main battery voltage and cell voltage fields.
mmosca
changed the title
mmosca
changed the title
DzikuVx
approved these changes
Dec 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The voltage display in BF compatibility mode loses 1 digit of precision.
Main battery voltage becomes an integer by default and cell voltage is reduced to a single digit.
This change would increase the number of characters by 1 in BF compatibility mode so it can display the expected number of decimal places.
Other video systems are not affected.
Main pack voltage seems like an important enough metric for this change.