Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed crsf attitude yaw overflow #8638

Merged
merged 1 commit into from Dec 23, 2022

Conversation

RomanLut
Copy link
Contributor

@RomanLut RomanLut commented Dec 20, 2022

angles in crsf attitude packet should be in range -PI...PI, passed in radians * 10000

IS: yaw is in range 0...3590
3590*1000 * PI / 180 = 62626
not in range of signed word

SHOULD: yaw should be in range -1800...1800

p.s. This is implemented correctly in betaflight https://github.com/betaflight/betaflight/blob/master/src/main/telemetry/crsf.c

@DzikuVx DzikuVx added this to the 6.0 milestone Dec 23, 2022
@DzikuVx DzikuVx merged commit 6ca6a6b into iNavFlight:master Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants