Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It looks like UBLOX ROM version 2.01 omits the = sign from PROTVER #9132

Merged
merged 3 commits into from Jun 18, 2023
Merged

It looks like UBLOX ROM version 2.01 omits the = sign from PROTVER #9132

merged 3 commits into from Jun 18, 2023

Conversation

mmosca
Copy link
Collaborator

@mmosca mmosca commented Jun 18, 2023 •
edited

@stronnag This may fix the protocol detection of your gps

SW: [2.01 (75331)] HW: 00080000 80000
ExtVer:  PROTVER 15.00
ExtVer:  GPS;SBAS;GLO;BDS;QZSS

Current code expect PROTVER=15.00 on the ExtVer field.

@stronnag
Copy link
Collaborator

Fixed detection on the ancient, non-up-gradable 2.01 device

@stronnag
Copy link
Collaborator

Can I persuade you to change gpsParceFrameUBLOX to gpsParseFrameUBLOX. Trivia I know.

@mmosca mmosca changed the title It looks like ROM version 2.01 ommits the = sign from PROTVER It looks like UBLOX ROM version 2.01 omits the = sign from PROTVER Jun 18, 2023
@stronnag stronnag merged commit ce4bac1 into master Jun 18, 2023
14 checks passed
@mmosca mmosca deleted the mosca-gps-ancient-m8-proto branch June 18, 2023 09:23
rmaia3d pushed a commit to rmaia3d/inav that referenced this pull request Jul 26, 2023
@mmosca @rmaia3d
It looks like UBLOX ROM version 2.01 omits the = sign from PROTVER (i…
cfc9264 
…NavFlight#9132)

* It looks like ROM version 2.01 ommits the = sign from PROTVER

* can't have strcmp in there

* s/gpsParceUBLOX/gpsParseUBLOX/g
sensei-hacker pushed a commit to sensei-hacker/inav_unofficial_targets that referenced this pull request Oct 4, 2023
@mmosca @sensei-hacker
It looks like UBLOX ROM version 2.01 omits the = sign from PROTVER (i…
29bbf43 
…NavFlight#9132)

* It looks like ROM version 2.01 ommits the = sign from PROTVER

* can't have strcmp in there

* s/gpsParceUBLOX/gpsParseUBLOX/g
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stronnag stronnag stronnag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmosca @stronnag