Enable the virtual pitot by default #9299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the virtual pitot by default. Since the huge improvement in accuracy in 6.0. The virtual pitot is now extremely useful. Currently for wind estimation. But, by enabling the virtual pitot by default, it paves the way for more changes based on airspeed. Such as using Airspeed PID Attenuation, instead of Throttle PID Attenuation. Throttle PID Attenuation can give completely inappropriate PIDs in some situations. For example, a low throttle dive, with a fast airspeed.
This change is obviously beneficial for fixed wing. The general consensus is that it would not have any negative effects on other platforms. Discussion starts here. @mmosca did you get the chance to fly your quad with virtual pitot enabled?