SAFETY issue -- servos.c: Correct servo throttle *off* when disarmed (not full throttle at disarm) #9330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sensei-hacker
changed the title
|
@sensei-hacker this might be a better solution #9413 |
|
what do you think? |
Looks good and tests good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When disarmed, the existing code is intended to set "servo" outputs that use throttle to minimum:
servo[target] = motorConfig()->mincommand;Which was expected to set the value to 1000.
However, the range at that point is intended to be -500 to +500.
servoParams(target)->middle is added a few lines later.
Therefore this ended up setting them to minimum + middle = 2500. Ie full throttle when disarmed.
PR subtracts servoParams(target)->middle, to offset the fact it's added a few lines later.
Tested by me and by INAV Discord user "driftingS13".