Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance mAh remaining OSD element #9334

Merged
merged 5 commits into from Oct 26, 2023

Conversation

MrD-RC
Copy link
Collaborator

@MrD-RC MrD-RC commented Oct 1, 2023

Increase the precision of the mAh remaining OSD element. This is to partner the mAh used element which had this change a couple of versions ago. Many packs are now more than 9999mAh. This change supports that.

Requires configurator iNavFlight/inav-configurator#1845

Release Notes

If you have previously used the osd_mah_used_precision parameter. This is now osd_mah_precision.

@MrD-RC MrD-RC added this to the 7.0 milestone Oct 1, 2023
@MrD-RC MrD-RC added Release Notes Add this when a PR needs to be mentioned in the release notes CLI Add this when new CLI commands needs to be added to docs labels Oct 4, 2023
@MrD-RC
Copy link
Collaborator Author

MrD-RC commented Oct 7, 2023

If someone with DJI could test this, I'd be grateful 👍🏻

@Zufallsgenerat0r
Copy link

Zufallsgenerat0r commented Oct 16, 2023

I would like to help testing this PR but wondering about the steps involved.

My steps would be:

  • Flash current stable version
  • Set the mAh remaining OSD element
  • Set a battery capacity higher than 9999mAh
  • Connect with DJI googles
  • Expect the element to be broken

  • Flash the version in this PR
  • Set the mAh remaining OSD element
  • Set a battery capacity higher than 9999mAh
  • Connect with DJI googles
  • Expect the element to show correctly

Are the steps in line with what you think should be done.
The only thing I don't have to do that is a battery with that high capacity but do I need it to do the testing? If I do could I fake it?

@MrD-RC
Copy link
Collaborator Author

MrD-RC commented Oct 23, 2023

@Zufallsgenerat0r currently with DJI, it will only show 4 digits for capacity remaining. With this change, it should have 5. You should just be able to set the battery capacity in Configurator to 10050 mAh, for example. This capacity should display incorrectly on the current stable release. But should be fine on this PR.

@DzikuVx DzikuVx merged commit 692c61c into master Oct 26, 2023
16 checks passed
@DzikuVx DzikuVx deleted the MrD_Enhance-mAh-remaining-OSD-Element branch October 26, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI Add this when new CLI commands needs to be added to docs Release Notes Add this when a PR needs to be mentioned in the release notes Requires Configurator Testing Required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants